Rewrite the robotic surgery Dockerfile to fix livestream issues #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingxin Zheng <[email protected]>
Contributor
Author
|
/build |
Nic-Ma
approved these changes
Jul 8, 2025
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Contributor
Author
|
/build |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates simulator version references, reorganizes Docker setup documentation, and rewrites the robotic surgery Dockerfile to use a CUDA-based image with Conda.
- Updated raytracing simulator links from v0.2.0rc1 to v0.2.0rc2
- Reworked Docker README for robotic_ultrasound and robotic_surgery with clearer prerequisites and run steps
- Replaced the robotic_surgery base image and install flow in its Dockerfile to use CUDA, apt dependencies, and Conda
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/robotic_ultrasound/scripts/simulation/README.md | Bumped Ultrasound Raytracing README link to rc2 |
| workflows/robotic_ultrasound/docker/README.md | Reorganized Docker instructions and corrected image tag to robotic_us |
| workflows/robotic_ultrasound/README.md | Updated asset‐catalog link to rc2 |
| workflows/robotic_surgery/docker/README.md | Rewritten Docker guide with new headings and run commands |
| workflows/robotic_surgery/docker/Dockerfile | Switched to nvidia/cuda:12.8.1-devel-ubuntu24.04 base and Conda flow |
| workflows/robotic_surgery/README.md | Updated asset‐catalog link to rc2 |
| tools/env_setup/install_isaac.sh | Updated asset‐catalog install line to rc2 |
Comments suppressed due to low confidence (2)
workflows/robotic_surgery/docker/README.md:44
- [nitpick] The indentation for this
-e "PRIVACY_CONSENT=Y" \line is inconsistent with the other flags. Please align it with the surrounding-eentries for readability.
-e "PRIVACY_CONSENT=Y" \
workflows/robotic_surgery/docker/README.md:45
- We need to mount the RTI license (e.g.,
-v ~/docker/rti:/root/rti:ro) and the asset cache (~/.cache/i4h-assets) here—otherwise the container won’t find required licenses or assets at runtime.
-v /tmp/.X11-unix:/tmp/.X11-unix \
mingxin-zheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates version for dependency (v0.2.0rc2), reorganizes Docker setup documentation for both robotic surgery and ultrasound, and rewrites the robotic surgery Dockerfile to use a CUDA-based image with Conda.